search

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
107.32k stars 29.46k forks source link

meta: IRC integration via github services deprecated #20563

Closed jasnell closed 6 years ago

jasnell commented 6 years ago

FYI... @nodejs/tsc @nodejs/automation

image

We currently use Github Services integration to facilitate the connection to the node-dev IRC channel. That integration mechanism has been deprecated by GitHub and will be going away soon.

devsnek commented 6 years ago

that bot hasn't worked for a long long time anyway because the irc channel is +n

Krinkle commented 6 years ago

Given this Node.js issue is the top result in Google for github services deprecated irc, here is a link with more information and relevant discussion:

https://platform.github.community/t/how-will-integrations-for-things-like-irc-notifications-work/326

Fishrock123 commented 6 years ago

I thought I gave the bot the correct auth stuff...

Fishrock123 commented 6 years ago

Oh, nope. I didn't. 😞

refack commented 6 years ago

Any news on the bot? I just checked the logs and it stopped posting on 12/25 just before the spambot attacked It's excluded from the slurp but this is aprox the last time http://logs.libuv.org/node-dev/2017-12-25#20:44:52.542

[2017-12-25 15:42:57] → mylesborins joined (~MylesBori@pdpc/supporter/student/thealphanerd)
[2017-12-25 15:42:57] * ChanServ set +o mylesborins
[2017-12-25 15:44:52] → nodejs-gh joined (nodejs-gh@gateway/service/github.com/x-jehpaorvkrafkmbw)
[2017-12-25 15:44:52] * [node] addaleax opened pull request #17864: test: make test-tls-invoke-queued use public API (master...tls-invoke-queued-test) https://git.io/vb7DF
[2017-12-25 15:44:52] ← nodejs-gh left (nodejs-gh@gateway/service/github.com/x-jehpaorvkrafkmbw): 
[2017-12-25 15:46:00] → pclinu535 joined (~prkyqv@170.233.40.148)
[2017-12-25 15:46:12] <pclinu535> ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ HAPPY
refack commented 6 years ago

Just after that

[2017-12-25 16:18:46] * mylesborins set channel modes +q $~a
[2017-12-25 16:18:54] <mylesborins> I've set /mode #yourchan +q $~a

/CC @MylesBorins (this might have blocked the IRCBot)

MylesBorins commented 6 years ago

The bot needs to be authenticated to work

On Fri, Jun 1, 2018, 1:10 AM Refael Ackermann notifications@github.com wrote:

Just after that

[2017-12-25 16:18:46] * mylesborins set channel modes +q $~a [2017-12-25 16:18:54] I've set /mode #yourchan +q $~a

/CC @MylesBorins https://github.com/MylesBorins (this might have blocked the IRCBot)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nodejs/node/issues/20563#issuecomment-393710816, or mute the thread https://github.com/notifications/unsubscribe-auth/AAecV6hfEkSqDhaUKc_t4f2000eEeWmrks5t4HhwgaJpZM4T0IFD .

ryzokuken commented 6 years ago

Should we change the bot to use the new API? Perhaps use a webhook if all we need is to just subscribe to events.