search

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
107.67k stars 29.64k forks source link

repl: REPL history seems broken in master and v11.2.0 #24385

Closed vsemozhetbyt closed 5 years ago

vsemozhetbyt commented 5 years ago

Can anybody reproduce?

vsemozhetbyt commented 5 years ago

I cannot reproduce with v11.1.0. I can reproduce with v11.2.0.

vsemozhetbyt commented 5 years ago

cc @antsmartian as per possible cause https://github.com/nodejs/node/pull/22153 backported in v11.2.0.

antsmartian commented 5 years ago

@vsemozhetbyt 😢 Yes, thats what caused the regression. My bad.

antsmartian commented 5 years ago

@vsemozhetbyt Working on a PR, on the way. Also, I guess we need to tighten our history test cases, as this should have been caught in first place :( :( .

caub commented 5 years ago

it's still broken in v11.3.0 peek 2018-12-01 21-52

vsemozhetbyt commented 5 years ago

11.3.0 was a security concerning release, so as per the changelog the fix was not backported yet,

vsemozhetbyt commented 5 years ago

The fix is on v11.x-staging branch, so this may be fixed in the next 11 release.

RichardBronosky commented 5 years ago

I install node via homebrew on macOS. Can someone please explain how I can get this fix?

caub commented 5 years ago

update node

RichardBronosky commented 5 years ago

I have

$ node -v
v11.13.0

and I am still getting this behavior.

caub commented 5 years ago

Oh, it might be a problem on macOS then, for me on v11.13.0 and linux, the problem doesn't exist anymore (it was fixed since v11.4.0 actually)

RichardBronosky commented 5 years ago

I was having a near breakdown from stress and didn't notice the difference between v11.3.0 and v11.13.0. I had for former version and the issue before upgrading to the later but didn't notice the number change and thought I was on the latter from the start. I then went out and bought a OneWheel to burn off some stress.

Thanks for the help though!