Closed targos closed 4 years ago
I think @thangktran left comments in a few places stating that these can be removed once V8 is updated to V8 8.0. I think that’s accurate.
Actually, some of the ArrayBuffer
s introduced there should maybe have the arraybuffer_untransferable_private_symbol
set, like we do in node_buffer.cc
, at least those whose memory isn’t actually being owned by the BackingStore
, like the HTTP2 js_fields_
one.
Actually, some of the
ArrayBuffer
s introduced there should maybe have thearraybuffer_untransferable_private_symbol
set, like we do innode_buffer.cc
, at least those whose memory isn’t actually being owned by theBackingStore
, like the HTTP2js_fields_
one.
should i provide a PR for this?
@thangktran I think that would be great, yes :+1:
I think this is resolved
We have warnings in canary.
node_v8.cc
:node_messaging.cc
:node_http2.cc
:node_buffer.cc
:js_native_api_v8.cc
: