search

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
107.27k stars 29.44k forks source link

Nominating @puzpuzpuz as a collaborator #32555

Closed addaleax closed 4 years ago

addaleax commented 4 years ago

@puzpuzpuz has been active for a while, particular around async_hooks and AsyncLocalStorage. I think it makes sense to have them join as a collaborator.

Issue Tracker: https://github.com/nodejs/node/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+involves%3Apuzpuzpuz Pull Requests: https://github.com/nodejs/node/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+author%3Apuzpuzpuz Reviews: https://github.com/nodejs/node/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+-author%3Apuzpuzpuz+reviewed-by%3Apuzpuzpuz+

vdeturckheim commented 4 years ago

Huge +1 here!

addaleax commented 4 years ago

With one week open, this nomination has been accepted! Congratulations, @puzpuzpuz! :tada:

I’ll reach out to you for scheduling an onboarding session using the email you use for contributing, I hope that works.

puzpuzpuz commented 4 years ago

@addaleax Many thanks for nominating me! It was a pleasant surprise for me to see this nomination.

As for the onboarding session, I've replied over the email.

addaleax commented 4 years ago

This has been done in https://github.com/nodejs/node/pull/32817 :)