Closed shackijj closed 4 years ago
The failure is because after https://github.com/nodejs/node/commit/fcc183c99413750b1b965e45cb42a1af73da47ab warnings are being treated as errors for non-deps code. The non-deps code was warning free at the beginning of the week -- unfortunately the V8 8.3 update landing has introduced new warnings, such as the one above (unfortunate in the sense that the actions/CI runs for the V8 update happened before we switched on the --errors-on-warn
flag, the idea being that having the flag on would help prevent PRs landing that introduced new warnings).
Can we do something apart from disabling --errors-on-warn
for macOS and reverting V8 8.3 update?
This might be fixed by https://github.com/nodejs/node/pull/32716 (which landed on the V8 canary branch)? cc @gengjiawen
In order to land, a Pull Request needs to be reviewed and approved by at least two Node.js Collaborators (one Collaborator approval is enough if the pull request has been open for more than 7 days) and pass a CI (Continuous Integration) test run.
The quote above is from this guide. Is landing of PRs an automated process? If yes, can we somehow improve it as to avoid merging commits that don't pass CI test run?
This might be fixed by #32716 (which landed on the V8 canary branch)? cc @gengjiawen
Yeap, need to cherrypick to master.
If yes, can we somehow improve it as to avoid merging commits that don't pass CI test run.
It passed the CI, just not rebased to the latest. We always land commit with full
CI pass.
This might be fixed by #32716 (which landed on the V8 canary branch)? cc @gengjiawen
Yeap, need to cherrypick to master.
MacOS builds fail on CI
Examples: https://github.com/nodejs/node/pull/33395/checks?check_run_id=673915168 https://github.com/nodejs/node/pull/33396/checks?check_run_id=673650394 https://github.com/nodejs/node/pull/33399/checks?check_run_id=674009996
The failure might be caused by this commit fcc183c99413750b1b965e45cb42a1af73da47ab. @richardlau is it OK that builds fail?