search

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
107.63k stars 29.61k forks source link

`request-ci` fails without error when CI is locked down #39746

Open targos opened 3 years ago

targos commented 3 years ago

See https://github.com/nodejs/node/pull/39725#event-5138829691

The request-ci label was removed but the request-ci-failed label was not added.

I don't know what the Jenkins API responds in this case, but it doesn't seem like we handle it.

Workflow run: https://github.com/nodejs/node/runs/3296324085?check_suite_focus=true

targos commented 3 years ago

@nodejs/actions

richardlau commented 3 years ago

We should handle the error but during a CI lockdown I think it's expected that request-ci would not start CI's.

targos commented 3 years ago

during a CI lockdown I think it's expected that request-ci would not start CI's

agreed

richardlau commented 3 years ago

I'm fairly certain this is a node-core-utils issue.