search

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
106.72k stars 29.11k forks source link

Node API core consolidation #44071

Open legendecas opened 2 years ago

legendecas commented 2 years ago

People are complaining that the node-api core implementation is deviating from node.js core conventions and has a lot of workarounds and non-conventional mechanisms, especially around the finalizers. It makes it harder to maintain the node-api code base.

I'm working with the @nodejs/node-api team on the document https://docs.google.com/document/d/1Bqm05PWQni65FVdSKiaVAkqCAOD9HIfCqG_Y4CAYTbo/edit?usp=sharing to list the problems we are facing and try to figure out what approaches we can apply.

@addaleax thanks for bringing the topic up at https://github.com/nodejs/node/pull/36510#discussion_r830628160.

Opening this issue to track the progress.

deepakrkris commented 2 years ago

I am interested in working on this

legendecas commented 2 years ago

@deepakrkris it will be great if you can help out on this! As we discussed in the last node-api team meeting, please free feel to drop a comment on the document if you have any questions.

mhdawson commented 12 months ago

@legendecas maybe we should go through this in the next node-api meeting to see what's been completed and what is still needed on this one.