search

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
107.09k stars 29.33k forks source link

Investigate console WPT failures without-intl and without-ssl #44185

Open panva opened 2 years ago

panva commented 2 years ago

43455 uncovered that the following WPT tests fail only on ubuntu1804_sharedlibs_withoutintl_x64 and ubuntu1804_sharedlibs_withoutssl_x64

The work in #43455 enabled WPT regressions to be caught in files with expected failures. These three tests were marked as flaky to allow the rest of the file to be tested and reported on.

[UNEXPECTED_FAILURE][FAIL] console namespace: operation table(optional any, optional sequence<DOMString>)
assert_equals: operation has wrong .length expected 0 but got 2
    at IdlNamespace.do_member_operation_asserts (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/idlharness.js:3212:5)
    at IdlNamespace.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/idlharness.js:3236:14)
    at Test.step (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/testharness.js:2590:25)
    at IdlNamespace.test_member_operation (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/idlharness.js:3230:12)
    at IdlNamespace.test (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/idlharness.js:3336:18)
Command: /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/node  /home/iojs/build/workspace/node-test-commit-linux-containered/test/wpt/test-console.js idlharness.any.js
[UNEXPECTED_FAILURE][FAIL] console namespace: operation dir(optional any, optional object?)
assert_equals: operation has wrong .length expected 0 but got 2
    at IdlNamespace.do_member_operation_asserts (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/idlharness.js:3212:5)
    at IdlNamespace.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/idlharness.js:3236:14)
    at Test.step (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/testharness.js:2590:25)
    at IdlNamespace.test_member_operation (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/idlharness.js:3230:12)
    at IdlNamespace.test (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/idlharness.js:3336:18)
Command: /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/node  /home/iojs/build/workspace/node-test-commit-linux-containered/test/wpt/test-console.js idlharness.any.js
[UNEXPECTED_FAILURE][FAIL] console namespace: operation assert(optional boolean, any...)
assert_equals: operation has wrong .length expected 0 but got 1
    at IdlNamespace.do_member_operation_asserts (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/idlharness.js:3212:5)
    at IdlNamespace.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/idlharness.js:3236:14)
    at Test.step (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/testharness.js:2590:25)
    at IdlNamespace.test_member_operation (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/idlharness.js:3230:12)
    at IdlNamespace.test (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/idlharness.js:3336:18)
Command: /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/node  /home/iojs/build/workspace/node-test-commit-linux-containered/test/wpt/test-console.js idlharness.any.js
panva commented 2 years ago

cc @nodejs/console

joyeecheung commented 2 years ago

They probably fail because we aren't wrapping the methods with inspector console calls in without-intl and without-ssl builds, where inspector isn't available. Not sure if they are worth fixing - we could fix that by either using arguments or making the methods native, but there is a non-trivial performance cost to pay.