Closed mhdawson closed 11 months ago
I did some bisection as part of https://github.com/nodejs/node/pull/49183 which was what led me to open this issue.
Using git bisect it seems to indicate that it was this PR that causes the failure:
0dc485eb28fb05eafad4dc78c646d917d8d4024a is the first bad commit
commit 0dc485eb28fb05eafad4dc78c646d917d8d4024a
Author: Yagiz Nizipli <yagiz@nizipli.com>
Date: Fri Mar 31 09:04:03 2023 -0400
url: drop ICU requirement for parsing hostnames
PR-URL: https://github.com/nodejs/node/pull/47339
Backport-PR-URL: https://github.com/nodejs/node/pull/48345
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
deps/ada/ada.gyp | 19 ++-----------------
doc/api/url.md | 25 +++++++++++++++----------
lib/internal/idna.js | 9 ++-------
test/benchmark/test-benchmark-url.js | 14 +-------------
test/wpt/status/url.json | 21 ---------------------
5 files changed, 20 insertions(+), 68 deletions(-)
@anonrig can you take a look at the backport and see if you can spot why it might be causing that test to fail?
We had a similar issue in the past: https://github.com/nodejs/node/issues/48262. Might be related to it. I'll take a look at it soon.
I think we should backport these 2 pull requests as well:
I think this is caused by calling domainToASCII
instead of ada::idna::to_ascii
.
https://github.com/nodejs/node/blob/v18.x-staging/lib/internal/idna.js#L3
Does this issue persist with the v18 proposal?
This was fixed in Node.js 18.18.0.
Version
v18.17.0
Platform
at least linux
Subsystem
net
What steps will reproduce the bug?
tools/test.py test/internet/test-dns-ipv6
How often does it reproduce? Is there a required condition?
100%
What is the expected behavior? Why is that the expected behavior?
Test passes
What do you see instead?
Test passes
Additional information
No response