nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
107.67k stars 29.63k forks source link

test-runner-watch-mode is flaky #49605

Open joyeecheung opened 1 year ago

joyeecheung commented 1 year ago
Reason parallel/test-runner-watch-mode
Type JS_TEST_FAILURE
Failed PR 5 (https://github.com/nodejs/node/pull/49419/, https://github.com/nodejs/node/pull/49559/, https://github.com/nodejs/node/pull/49565/, https://github.com/nodejs/node/pull/49575/, https://github.com/nodejs/node/pull/49582/)
Appeared test-osuosl-ubuntu2004_container-armv7l-1, test-digitalocean-ubuntu1804_sharedlibs_container-x64-2
First CI https://ci.nodejs.org/job/node-test-pull-request/53812/
Last CI https://ci.nodejs.org/job/node-test-pull-request/53856/
Example ``` not ok 2874 parallel/test-runner-watch-mode --- duration_ms: 360086.13100 severity: fail exitcode: -15 stack: |- timeout TAP version 13 Updating /home/iojs/tmp/.tmp.2382/dependent.js Updating /home/iojs/tmp/.tmp.2382/dependent.js Updating /home/iojs/tmp/.tmp.2382/dependent.js Updating /home/iojs/tmp/.tmp.2382/dependent.js Updating /home/iojs/tmp/.tmp.2382/dependent.js Updating /home/iojs/tmp/.tmp.2382/dependent.js Updating /home/iojs/tmp/.tmp.2382/dependent.js Updating /home/iojs/tmp/.tmp.2382/dependent.js Updating /home/iojs/tmp/.tmp.2382/dependent.js Updating /home/iojs/tmp/.tmp.2382/dependent.js Updating /home/iojs/tmp/.tmp.2382/dependent.js # Subtest: test runner watch mode # Subtest: should run tests repeatedly ok 1 - should run tests repeatedly --- duration_ms: 1301.051293 ... ```

Refs: https://github.com/nodejs/reliability/issues/662

From the full log it looks like something is quite wrong in the test, it keeps getting stuck at tons of Updating /home/iojs/node-tmp/.tmp.2479/dependency.js until the 2 minute timeout is reached (my guess is it has more to do with how the test is written)

https://ci.nodejs.org/job/node-test-binary-armv7l/7355/RUN_SUBSET=js,nodes=ubuntu2004-armv7l/consoleText

joyeecheung commented 1 year ago

cc @nodejs/test_runner

MoLow commented 1 year ago

is anyone able to reproduce with tools/test.py --repeat=1000 test/parallel/test-runner-watch-mode.mjs? on my machine it passes smoothly

aduh95 commented 1 year ago

I'm also unable to reproduce on macOS (Apple Silicon)

On 11 Sep 2023, at 20:43, Moshe Atlow @.***> wrote:

is anyone able to reproduce with tools/test.py --repeat=1000 test/parallel/test-runner-watch-mode.mjs?

— Reply to this email directly, view it on GitHub https://github.com/nodejs/node/issues/49605#issuecomment-1714399222, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADNFTDL5SQPSJ6DLA3ZAKCLXZ5LTJANCNFSM6AAAAAA4TFU45E. You are receiving this because you are on a team that was mentioned.

joyeecheung commented 1 year ago

The flakes in the CI only show up in Linux ARM and Linux + shared library. I am guessing using a similar setup may help reproducing the issues. Or you can try using the the CI boxes.

joyeecheung commented 1 year ago

Looks like this also comes up to people running Ubuntu 22.04 locally too https://github.com/nodejs/node/issues/49513

aduh95 commented 2 months ago

Happened again on https://ci.nodejs.org/job/node-test-commit-linuxone/45127/nodes=rhel8-s390x/