search

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
104.51k stars 28.19k forks source link

lib: update params in jsdoc for `HTTPRequestOptions` #49872

Closed pluris closed 8 months ago

pluris commented 8 months ago

A missing parameter was added to the jsdoc of HTTPRequestOptions.

https://github.com/nodejs/node/blob/main/doc/api/http.md#httprequesturl-options-callback

nodejs-github-bot commented 8 months ago

Review requested:

nodejs-github-bot commented 8 months ago

CI: https://ci.nodejs.org/job/node-test-pull-request/54246/

aduh95 commented 8 months ago

Landed in https://github.com/nodejs/node/commit/6aa7101960b7fd6af32d2cf9bd7b7dbd8b91f30c

leonardoadame commented 6 months ago

pluris:lib/update_jsdoc_http https://github.com/nodejs/node/pull/49872#pullrequestreview-1644303117 https://github.com/nodejs/node/pull/49872#issuecomment-1735184288