Open mctrafik opened 9 months ago
Please confirm this issue and what should be the expected behavior. I would love to work on this issue.
@pulkit-30 Are you asking me to confirm something, or was your reply an internal conversation?
@pulkit-30 Are you asking me to confirm something
not you @mctrafik, to @nodejs/http2
This appears to be an issue in the "http2-express-bridge" library. There already seems to be a PR for this: https://github.com/rahulramesha/http2-express-bridge/pull/9
@Primexz Great find. Thanks.
I'm not versed in this code, but is there something to be done on the node side to indicate that the exception is thrown in a lib?
Version
v20.9.0
Platform
Darwin KH7JWKR9RD 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct 9 21:27:24 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6000 arm64
Subsystem
No response
What steps will reproduce the bug?
I am trying to write an insecure HTTP2 web server. However it crashes on any inputs.
Code to reproduce:
when I run the server and then query it with
curl --insecure -v -k --http2-prior-knowledge "http://[::]:8080"
it crashes with a short stacktrace deep within node that I'm unable to debug/troubleshoot.How often does it reproduce? Is there a required condition?
Happens every time.
What is the expected behavior? Why is that the expected behavior?
When I add an SSL cert to this server, and run
createSecureServer
instead ofcreateServer
, everything work fine.What do you see instead?
Instead
curl
hangs, and the server crashes with the following stack trace:Additional information
As you can see this only happens when there's no SSL and stracktrace contains no other pointer for me to latch onto.