nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
106.41k stars 28.99k forks source link

Migration of the GitHub bot from our infra to GitHub actions #51236

Open targos opened 8 months ago

targos commented 8 months ago

Maintenance of the GitHub bot has become a problem. The machine it's running on is on a quite old version of Debian that doesn't support recent versions of Node.js and we have very few people who know and work on the bot's code (https://github.com/nodejs/github-bot).

I'd like to know if collaborators would be willing to help with a migration of the bot's features to GitHub actions and/or Jenkins plugins/scripts that talk directly to GitHub.

Those features are:

@nodejs/actions @nodejs/github-bot

marco-ippolito commented 8 months ago

Arent these action already triggered by a github action, for example when a PR is opened?

targos commented 8 months ago

No, they're triggered by a github webhook.

phillipj commented 8 months ago

Chiming in with some historical context in case it would be helpful:

Regarding the last point, if Jenkins could talk directly with Github instead these days, that sounds reasonable for less indirection 👍🏻

targos commented 8 months ago

We can probably do something with https://github.com/jenkinsci/github-checks-plugin

RedYetiDev commented 2 months ago

Ping code owners when a PR is opened: https://github.com/nodejs/github-bot/blob/main/scripts/node-ping-owners.js

https://github.com/nodejs/node/issues/53149 https://github.com/nodejs/github-bot/pull/521