Closed bekcpear closed 3 weeks ago
- Loading data for nodejs/node/pull/51528 ✔ Done loading data for nodejs/node/pull/51528 ----------------------------------- PR info ------------------------------------ Title benchmark: fix api restriction for the permission category (#51528) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch bekcpear:benchmark-permission-fix -> nodejs:main Labels benchmark, author ready, permission Commits 2 - benchmark: fix api restriction for the permission category - Update benchmark/permission/permission-startup.js Committers 2 - Antoine du Hamelhttps://github.com/nodejs/node/actions/runs/9139117635- GitHub PR-URL: https://github.com/nodejs/node/pull/51528 Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51528 Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 19 Jan 2024 15:27:32 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51528#pullrequestreview-1833462899 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/51528#pullrequestreview-1956583886 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/51528#pullrequestreview-2064693399 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51528 From https://github.com/nodejs/node * branch refs/pull/51528/merge -> FETCH_HEAD ✔ Fetched commits as eaa839ed8ab4..be98c2b0b23c -------------------------------------------------------------------------------- [main 707170ed86] benchmark: fix api restriction for the permission category Author: Ryan Qian Date: Fri Jan 19 22:51:18 2024 +0800 2 files changed, 6 insertions(+), 3 deletions(-) [main d07dad029f] Update benchmark/permission/permission-startup.js Author: Antoine du Hamel Date: Thu May 16 21:19:29 2024 +0200 1 file changed, 2 insertions(+), 4 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes ⚠ Found Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read, skipping.. --------------------------------- New Message ---------------------------------- benchmark: fix api restriction for the permission category give appropriate permissions to the following scripts: * permission-processhas-fs-read.js: 'ChildProcess' permission * permission-startup.js: 'FileSystemRead' permission > Paths delimited by comma (,) are no longer allowed. Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read Signed-off-by: Ryan Qian PR-URL: https://github.com/nodejs/node/pull/51528 Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- [detached HEAD 33758aeb4b] benchmark: fix api restriction for the permission category Author: Ryan Qian Date: Fri Jan 19 22:51:18 2024 +0800 2 files changed, 6 insertions(+), 3 deletions(-) Rebasing (3/4) Rebasing (4/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- Update benchmark/permission/permission-startup.js PR-URL: https://github.com/nodejs/node/pull/51528 Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- [detached HEAD d85d69b123] Update benchmark/permission/permission-startup.js Author: Antoine du Hamel Date: Thu May 16 21:19:29 2024 +0200 1 file changed, 2 insertions(+), 4 deletions(-) Successfully rebased and updated refs/heads/main. -------------------------------------------------------------------------------- ℹ Add `commit-queue-squash` label to land the PR as one commit, or `commit-queue-rebase` to land as separate commits.
Landed in 8216cc964e76d0849dfb829181d831e0df9554a3
give appropriate permissions to the following scripts:
Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read