Missing `Http2ServerResponse.setHeaders()` - Githubissues

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨

https://nodejs.org

Other

107.46k stars 29.55k forks source link

Missing `Http2ServerResponse.setHeaders()` #51573

Open danfuzz opened 9 months ago

danfuzz commented 9 months ago

What is the problem this feature will solve?

Make it possible to use response.setHeaders() on both old HTTP response objects and ones coming from node:http2.

BTW I wasn't sure if this should be a "feature request" or a "bug."

What is the feature you are proposing to solve the problem?

Add the method http2.Http2ServerResponse.setHeaders() to have the same API as http.OutgoingMessage.setHeaders().

See https://nodejs.org/api/http.html#outgoingmessagesetheadersheaders.

What alternatives have you considered?

Avoiding using setHeaders() at all.
Monkey-patching Http2ServerResponse.
Just writing two versions of my own set-headers code, on the assumption that, when available, setHeaders() is the most efficient option.

github-actions[bot] commented 3 months ago

There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the https://github.com/nodejs/node/labels/never-stale label or close this issue if it should be closed. If not, the issue will be automatically closed 6 months after the last non-automated comment. For more information on how the project manages feature requests, please consult the feature request management document.