Open targos opened 5 months ago
@addaleax ... in test-worker-arraybuffer-zerofill.js... do you happen to remember why the test needed to allocate such huge buffers so often?
function allocBuffers() {
Buffer.allocUnsafe(32 * 1024 * 1024);
}
const interval = setInterval(allocBuffers, 0);
I think this is what is leading to the timeout flakiness in the test.
This file was last changed five years ago so I'll understand if you don't remember ;-)
Btw, I'm assuming it's to ensure that the allocation is expensive enough to ensure that it is likely still running when the other thread allocates?
Test
test-worker-arraybuffer-zerofill
Platform
No response
Console output
Build links
Additional information
test-worker-arraybuffer-zerofill
: this could be a real bug, or some timing assumptions being broken/messages getting lost (which may also be a real bug). We can mark it as flaky for now, and add some logs in the test to help debugging.Originally posted by @joyeecheung in https://github.com/nodejs/node/issues/51362#issuecomment-2023338163