nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
105.01k stars 28.44k forks source link

flaky: benchmark/test-benchmark-crypto #52690

Open mhdawson opened 2 months ago

mhdawson commented 2 months ago

Test

test-benchmark-crypto

Platform

Linux x64

Console output

11:19:53 not ok 4009 benchmark/test-benchmark-crypto
11:19:53   ---
11:19:53   duration_ms: 3234.66800
11:19:53   severity: fail
11:19:53   exitcode: 1
11:19:53   stack: |-
11:19:53     node:assert:126
11:19:53       throw new AssertionError(obj);
11:19:53       ^
11:19:53     
11:19:53     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
11:19:53     
11:19:53     1 !== 0
11:19:53     
11:19:53         at main (/home/iojs/build/workspace/node-test-commit-linux/benchmark/crypto/timingSafeEqual.js:21:10)
11:19:53         at /home/iojs/build/workspace/node-test-commit-linux/benchmark/common.js:54:9
11:19:53         at process.processTicksAndRejections (node:internal/process/task_queues:77:11) {
11:19:53       generatedMessage: true,
11:19:53       code: 'ERR_ASSERTION',
11:19:53       actual: 1,
11:19:53       expected: 0,
11:19:53       operator: 'strictEqual'
11:19:53     }
11:19:53     
11:19:53     Node.js v22.0.0-pre
11:19:53     node:assert:126
11:19:53       throw new AssertionError(obj);
11:19:53       ^
11:19:53     
11:19:53     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
11:19:53     
11:19:53     1 !== 0
11:19:53     
11:19:53         at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/test/common/benchmark.js:28:12)
11:19:53         at ChildProcess.emit (node:events:520:28)
11:19:53         at ChildProcess._handle.onexit (node:internal/child_process:294:12) {
11:19:53       generatedMessage: true,
11:19:53       code: 'ERR_ASSERTION',
11:19:53       actual: 1,
11:19:53       expected: 0,
11:19:53       operator: 'strictEqual'
11:19:53     }
11:19:53     
11:19:53     Node.js v22.0.0-pre

Build links

Additional information

No response

richardlau commented 2 months ago

Given this stack trace

11:19:53         at main (/home/iojs/build/workspace/node-test-commit-linux/benchmark/crypto/timingSafeEqual.js:21:10)

this is most likely going to be for the same reason as https://github.com/nodejs/node/issues/38226.

jakecastelli commented 2 weeks ago

Flaky again here in this PR

see Detail ``` not ok 4016 benchmark/test-benchmark-crypto 19:42:55 --- 19:42:55 duration_ms: 2513.95400 19:42:55 severity: fail 19:42:55 exitcode: 1 19:42:55 stack: |- 19:42:55 node:assert:126 19:42:55 throw new AssertionError(obj); 19:42:55 ^ 19:42:55 19:42:55 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: 19:42:55 19:42:55 1 !== 0 19:42:55 19:42:55 at main (/home/iojs/build/workspace/node-test-commit-linux-containered/benchmark/crypto/timingSafeEqual.js:21:10) 19:42:55 at /home/iojs/build/workspace/node-test-commit-linux-containered/benchmark/common.js:54:9 19:42:55 at process.processTicksAndRejections (node:internal/process/task_queues:77:11) { 19:42:55 generatedMessage: true, 19:42:55 code: 'ERR_ASSERTION', 19:42:55 actual: 1, 19:42:55 expected: 0, 19:42:55 operator: 'strictEqual' 19:42:55 } 19:42:55 19:42:55 Node.js v23.0.0-pre 19:42:55 node:assert:126 19:42:55 throw new AssertionError(obj); 19:42:55 ^ 19:42:55 19:42:55 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: 19:42:55 19:42:55 1 !== 0 19:42:55 19:42:55 at ChildProcess. (/home/iojs/build/workspace/node-test-commit-linux-containered/test/common/benchmark.js:28:12) 19:42:55 at ChildProcess.emit (node:events:520:28) 19:42:55 at ChildProcess._handle.onexit (node:internal/child_process:294:12) { 19:42:55 generatedMessage: true, 19:42:55 code: 'ERR_ASSERTION', 19:42:55 actual: 1, 19:42:55 expected: 0, 19:42:55 operator: 'strictEqual' 19:42:55 } ```