nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
107.81k stars 29.71k forks source link

v22.0.0 breaks --v8-lite-mode build missing action for js-to-wasm-tq-csa.cc #52710

Closed davidfiala closed 5 months ago

davidfiala commented 6 months ago

Version

22.0.0

Platform

Linux x86_64 Alpine 3.19.1

Subsystem

No response

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

No response

What do you see instead?

# ./configure --ninja --v8-lite-mode && ninja -C out/Release node
Node.js configure: Found Python 3.11.9...
INFO: configure completed successfully
ninja: entering directory 'out/Release'
ninja: file is missing and not created by any action: 'gen/torque-generated/src/builtins/js-to-wasm-tq-csa.cc'

Additional information

Last seen working on v21.7.3 commit in git. Seems exclusive to v22.0.0 tag.

davidfiala commented 6 months ago

I'm going to guess it is related to https://github.com/nodejs/node/commit/4e278f0253aae908e56c084637d2ec2a04a2e202 where perhaps that target isn't being deselected in v8 lite mode.

PR and Bug related:

PR on not including wasm in lite mode:

daeyeon commented 6 months ago

Thank you for the detailed report. I opened a PR. PTAL.