search

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
104.27k stars 28.06k forks source link

test: drop test-crypto-timing-safe-equal-benchmarks #52751

Closed RafaelGSS closed 2 weeks ago

RafaelGSS commented 2 weeks ago

This has been constantly failing on macOS recently and given to the fact an issue has been opened since 2021 and no one worked on that, we should just drop it. Please note, that timing benchmarks tend to be flaky at some point, so we might want to test it differently.

Refs: https://github.com/nodejs/node/issues/38226

cc: @Trott @mhdawson @richardlau

richardlau commented 2 weeks ago

Can you remove the flaky entries from the status file as well?

RafaelGSS commented 2 weeks ago

Can you remove the flaky entries from the status file as well?

Done

nodejs-github-bot commented 2 weeks ago

CI: https://ci.nodejs.org/job/node-test-pull-request/58806/

nodejs-github-bot commented 2 weeks ago

CI: https://ci.nodejs.org/job/node-test-pull-request/58809/

nodejs-github-bot commented 2 weeks ago

CI: https://ci.nodejs.org/job/node-test-pull-request/58813/

lpinca commented 2 weeks ago

cc @tniessen

nodejs-github-bot commented 2 weeks ago

Landed in b876e00b47ec1e7fe356e6876e19e46c08ccef10