nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
104.27k stars 28.06k forks source link

watch: fix arguments parsing #52760

Closed MoLow closed 2 weeks ago

MoLow commented 2 weeks ago

Fixes https://github.com/nodejs/node/issues/52704

MoLow commented 2 weeks ago

@rluvaton added. can you please re-approve?

nodejs-github-bot commented 2 weeks ago

CI: https://ci.nodejs.org/job/node-test-pull-request/58833/

nodejs-github-bot commented 2 weeks ago

CI: https://ci.nodejs.org/job/node-test-pull-request/58836/

nodejs-github-bot commented 2 weeks ago

CI: https://ci.nodejs.org/job/node-test-pull-request/58853/

nodejs-github-bot commented 2 weeks ago

CI: https://ci.nodejs.org/job/node-test-pull-request/58855/

nodejs-github-bot commented 2 weeks ago

CI: https://ci.nodejs.org/job/node-test-pull-request/58859/

nodejs-github-bot commented 2 weeks ago
Commit Queue failed
- Loading data for nodejs/node/pull/52760
✔  Done loading data for nodejs/node/pull/52760
----------------------------------- PR info ------------------------------------
Title      watch: fix arguments parsing (#52760)
Author     Moshe Atlow  (@MoLow)
Branch     MoLow:fix-watch-mode-args -> nodejs:main
Labels     author ready, needs-ci, watch-mode
Commits    6
 - watch: fix arguments parsing
 - CR
 - fix test
 - fix test
 - CR
 - CR
Committers 1
 - Moshe Atlow 
PR-URL: https://github.com/nodejs/node/pull/52760
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52760
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 30 Apr 2024 15:27:18 GMT
   ✔  Approvals: 2
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/52760#pullrequestreview-2031899284
   ✔  - Raz Luvaton (@rluvaton): https://github.com/nodejs/node/pull/52760#pullrequestreview-2033469033
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-05-02T10:19:49Z: https://ci.nodejs.org/job/node-test-pull-request/58859/
- Querying data for job/node-test-pull-request/58859/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 52760
From https://github.com/nodejs/node
 * branch                  refs/pull/52760/merge -> FETCH_HEAD
✔  Fetched commits as 08c3256527eb..4a23ab6af99e
--------------------------------------------------------------------------------
[main 162b20f0cb] watch: fix arguments parsing
 Author: Moshe Atlow 
 Date: Tue Apr 30 18:14:21 2024 +0300
 2 files changed, 20 insertions(+), 3 deletions(-)
[main e53d773384] CR
 Author: Moshe Atlow 
 Date: Tue Apr 30 18:34:50 2024 +0300
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 91d872af21] fix test
 Author: Moshe Atlow 
 Date: Tue Apr 30 19:28:05 2024 +0300
 1 file changed, 2 insertions(+), 2 deletions(-)
[main 3f8e7cf369] fix test
 Author: Moshe Atlow 
 Date: Tue Apr 30 19:31:25 2024 +0300
 1 file changed, 4 insertions(+), 2 deletions(-)
[main eabb33cc91] CR
 Author: Moshe Atlow 
 Date: Wed May 1 13:17:19 2024 +0300
 1 file changed, 26 insertions(+), 1 deletion(-)
[main 85dab0edeb] CR
 Author: Moshe Atlow 
 Date: Wed May 1 14:16:05 2024 +0300
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 6 commits in the PR. Attempting autorebase.
Rebasing (2/12)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
watch: fix arguments parsing

PR-URL: https://github.com/nodejs/node/pull/52760
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
--------------------------------------------------------------------------------
[detached HEAD 71fb278ffd] watch: fix arguments parsing
 Author: Moshe Atlow 
 Date: Tue Apr 30 18:14:21 2024 +0300
 2 files changed, 20 insertions(+), 3 deletions(-)
Rebasing (3/12)
Rebasing (4/12)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
CR

PR-URL: https://github.com/nodejs/node/pull/52760
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
--------------------------------------------------------------------------------
[detached HEAD 1ed3f345a7] CR
 Author: Moshe Atlow 
 Date: Tue Apr 30 18:34:50 2024 +0300
 1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (5/12)
Rebasing (6/12)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix test

PR-URL: https://github.com/nodejs/node/pull/52760
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
--------------------------------------------------------------------------------
[detached HEAD 9db47ed615] fix test
 Author: Moshe Atlow 
 Date: Tue Apr 30 19:28:05 2024 +0300
 1 file changed, 2 insertions(+), 2 deletions(-)
Rebasing (7/12)
Rebasing (8/12)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix test

PR-URL: https://github.com/nodejs/node/pull/52760
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
--------------------------------------------------------------------------------
[detached HEAD 0575ab69a9] fix test
 Author: Moshe Atlow 
 Date: Tue Apr 30 19:31:25 2024 +0300
 1 file changed, 4 insertions(+), 2 deletions(-)
Rebasing (9/12)
Rebasing (10/12)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
CR

PR-URL: https://github.com/nodejs/node/pull/52760
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
--------------------------------------------------------------------------------
[detached HEAD 4d934d5fb6] CR
 Author: Moshe Atlow 
 Date: Wed May 1 13:17:19 2024 +0300
 1 file changed, 26 insertions(+), 1 deletion(-)
Rebasing (11/12)
Rebasing (12/12)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
CR

PR-URL: https://github.com/nodejs/node/pull/52760
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
--------------------------------------------------------------------------------
[detached HEAD 95bc1a63b5] CR
 Author: Moshe Atlow 
 Date: Wed May 1 14:16:05 2024 +0300
 1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.
--------------------------------------------------------------------------------
   ℹ  Add `commit-queue-squash` label to land the PR as one commit, or `commit-queue-rebase` to land as separate commits.
https://github.com/nodejs/node/actions/runs/8926528811
nodejs-github-bot commented 2 weeks ago

Landed in 905ab3e9ecfe2881950e8485e9c5f4f48d30315f