[v20.x backport] streams: fixes for webstreams

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨

https://nodejs.org

Other

104.27k stars 28.05k forks source link

[v20.x backport] streams: fixes for webstreams #52773

Open MattiasBuelens opened 2 weeks ago

MattiasBuelens commented 2 weeks ago

Manual backport of #51168 to v20.x. Depends on #52772, so keeping this in draft until that one lands.

This one was a bit tricky, since there are changes to transferables on v22.x that are not on v20.x (such as #50107) which also affect web streams. However, I think I made it work. 🤞

nodejs-github-bot commented 2 weeks ago

Review requested:

[ ] @nodejs/web-standards

marco-ippolito commented 22 hours ago

can you fix the conflicts? I'll try to backport it in the next v20 release

MattiasBuelens commented 10 hours ago

@marco-ippolito Updated and ready for review. 😉

nodejs-github-bot commented 1 hour ago

CI: https://ci.nodejs.org/job/node-test-pull-request/59263/