search

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
104.27k stars 28.06k forks source link

fs: add support for minimatch overrides #52789

Closed RedYetiDev closed 2 weeks ago

RedYetiDev commented 2 weeks ago

This PR adds an additional overrides parameter to the options argument of fs.glob. This allows users to override the default minimatch glob options.

Fixes #52779

tniessen commented 2 weeks ago

If folks want to expose minimatch's API details to Node.js users, why is there fs.glob() with a different API in the first place?

MoLow commented 2 weeks ago

I also am not sure this is the ask in https://github.com/nodejs/node/issues/52779 - see https://github.com/nodejs/node/issues/52779#issuecomment-2090280411

climba03003 commented 2 weeks ago

I believe it more like to ask support for glob string or array in the exclude option.

RedYetiDev commented 2 weeks ago

Yes, that sounds like a better idea.