search

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
104.51k stars 28.19k forks source link

`AttachCppHeap` and `DetachCppHeap` are deprecated in V8 #52999

Closed targos closed 1 week ago

targos commented 2 weeks ago 
../../src/env.cc:569:14: warning: 'AttachCppHeap' is deprecated: Set the heap on Isolate creation using CreateParams instead. [-Wdeprecated-declarations]
    isolate->AttachCppHeap(cpp_heap_.get());
             ^
../../deps/v8/include/v8-isolate.h:1047:3: note: 'AttachCppHeap' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON(
  ^

../../src/env.cc:600:15: warning: 'DetachCppHeap' is deprecated: Set the heap on Isolate creation using CreateParams instead. [-Wdeprecated-declarations]
    isolate_->DetachCppHeap();
              ^
../../deps/v8/include/v8-isolate.h:1056:3: note: 'DetachCppHeap' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON(
  ^
juanarbol commented 1 week ago

I can work on this one :)

targos commented 1 week ago

@juanarbol Sorry this is actually a duplicate of https://github.com/nodejs/node/issues/52718. I forgot that I moved that issue. https://github.com/nodejs/node/pull/53038 is fixing it.