nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
104.51k stars 28.19k forks source link

tools: move webcrypto into no-restricted-properties #53023

Closed ZihongQu closed 1 day ago

ZihongQu commented 2 weeks ago

Since eslint fixed https://github.com/eslint/eslint/issues/16412 in v8.56.0 here and we are on eslint v8.57.0 so that we can take advantage of no-restricted-properties rule for webcrypto.

This is my first pull request to node.js. Please let me know if there is anything to fix.

nodejs-github-bot commented 1 week ago

CI: https://ci.nodejs.org/job/node-test-pull-request/59362/

nodejs-github-bot commented 1 week ago

CI: https://ci.nodejs.org/job/node-test-pull-request/59369/

nodejs-github-bot commented 1 week ago

CI: https://ci.nodejs.org/job/node-test-pull-request/59375/

aduh95 commented 1 week ago

Can you rebase please? With the move to flat config, there are some conflicts to solve.

ZihongQu commented 6 days ago

Can you rebase please? With the move to flat config, there are some conflicts to solve.

Hi @aduh95, I have rebased my branch. Could you please take a look again and rerun CI for me? Thanks.

I have also removed my TODO as the upgrade of Eslint from v8 to v9 does not cause errors in the test files anymore.

aduh95 commented 6 days ago

The linter is failing (also it looks like the TODO is still there?)

ZihongQu commented 6 days ago

The linter is failing (also it looks like the TODO is still there?)

Oh sorry. I accidentally dropped one of my commit during interactive rebase. Thank you for spotting it! It should be fixed by now.

nodejs-github-bot commented 5 days ago

CI: https://ci.nodejs.org/job/node-test-pull-request/59431/

nodejs-github-bot commented 4 days ago

CI: https://ci.nodejs.org/job/node-test-pull-request/59464/

ZihongQu commented 2 days ago

Hi @aduh95, I am still seeing 4 failing CI jobs (feels like flaky tests) could you help me take a look, please? Thanks a lot ! 👀

nodejs-github-bot commented 2 days ago

CI: https://ci.nodejs.org/job/node-test-pull-request/59536/

nodejs-github-bot commented 1 day ago

Landed in 74dff83fad3918b20f219c03259088e55930c226