nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
105.21k stars 28.5k forks source link

Update Undici to backport a fix in Node.js 20.x #53186

Open QuiiBz opened 1 month ago

QuiiBz commented 1 month ago

What is the problem this feature will solve?

AWS Lambda recently completed a rollout from Node.js 20.12.x to Node.js 20.13.x, which includes this bug reported to Undici.

This impacts users using Node.js 20 in AWS Lambda, Netlify, Vercel, or any other service that uses AWS Lambda.

For example:

What is the feature you are proposing to solve the problem?

Update Undici to (at least) version 6.17.0 for the next Node.js 20 minor version, to includes the upstream fix. cc @mcollina

What alternatives have you considered?

No response

mcollina commented 1 month ago

@marco-ippolito can you include https://github.com/nodejs/node/pull/53034 in the upcoming v20 release?

QuiiBz commented 2 weeks ago

Will be closed by https://github.com/nodejs/node/pull/53486 once it's released - it bumps Undici to 6.17.0, which includes the fix.

Edit: no longer planed for next release: https://github.com/nodejs/node/pull/53486#issuecomment-2178158387