search

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
106.52k stars 29.03k forks source link

Linking uses too much memory when building v22.2.0 on macOS #53216

Open ncihnegn opened 3 months ago

ncihnegn commented 3 months ago

Version

22.2.0

Platform

MBP 13 M1 23.5.0 Darwin Kernel Version 23.5.0: Wed May 1 20:16:51 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_T8103 arm64

Subsystem

No response

What steps will reproduce the bug?

Build from source

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

No response

What do you see instead?

Linking node_mksnapshot memory usage kept growing to 50GB before I killed it.

Additional information

No response

targos commented 3 months ago

I don't know how it happened to you but my mac "only" has a total of 32GB of RAM and it compiles Node.js without issues.

MrJithil commented 3 months ago

Could you please provide the exact configuration you ran? Also, the model number/name.

Configuration file - ./config.mk

ncihnegn commented 3 months ago

config.mk

# Do not edit. Generated by the configure script.
BUILDTYPE=Release
NODE_TARGET_TYPE=executable
PYTHON=/usr/local/opt/python/bin/python3.12
PREFIX=/usr/local/Cellar/node/22.2.0

MBP 13 M1

MrJithil commented 3 months ago

config.mk

# Do not edit. Generated by the configure script.
BUILDTYPE=Release
NODE_TARGET_TYPE=executable
PYTHON=/usr/local/opt/python/bin/python3.12
PREFIX=/usr/local/Cellar/node/22.2.0

What model do you mean? MacBook model?

Yes. So that some of the contributors having similar mac model will try with the above config. You can edit the above comment and add it there. It will be easier to grab at a glance.