search

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
105.15k stars 28.49k forks source link

doc: remove scroll up when highlighting text #53594

Open KostiantynO opened 1 week ago

KostiantynO commented 1 week ago

Affected URL(s)

https://nodejs.org/docs/latest/api/stream.html

Description of the problem

Hello! I have experienced a bug with docs: When I try to select a code snippet, the scrolling goes up very fast.

Highlight any text with mouse:

Current result: it selects unwanted information above the highlighted part of text, because of excessive scrolling up. Expected result: It only selects the highlighted text.

Selecting text in Node.js docs send scroll up to the moon

This decreases the usability of the docs significantly, because I can only read them, and cannot reliably copy any text I want to select.

Such problem does not exist in react docs. But in node.js it does exist, and such inconsistency is unacceptable UX.

Suggesting: Node.js do have a very large pages. Maybe it will be better to split them into smaller sections for better usability.

System: OS: Windows 10 Home 22H2 (OS build 19045.4529) Browser: Chrome Version 126.0.6478.116 (Official Build) (64-bit)

RedYetiDev commented 1 week ago

@nodejs/documentation (The documentation team) @ovflowd (Preparing a redesign FWIW IIRC, React has a different page for each item, while Node.js has a different page for each subsystem. The two projects are documenting much different things.

KostiantynO commented 3 days ago

I just want to select text on the page. I have a very specific need for this. Can it be done in node docs? In react docs any page does not scroll up, while in node docs every page is bugged. I cannot select small portion of a text, because mouse goes to the sky like on provided gif. I would try to help with this in spare time, if it can be done.

RedYetiDev commented 3 days ago

I see the issue you are describing, but your issue is asking to split the docs like React. if you have an issue with the scrolling, please dedicate an issue directly to that.

RedYetiDev commented 3 days ago

A fix for the behavior you described is underway

KostiantynO commented 1 day ago

Oh, thank you! So, people already submitted a PR for node 22 and 17, and are waiting for review. So, this scroll-padding-top on body is to show header in correct position?

P.S. It is fun that backend docs site suffer from pesky CSS bugs :D