nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
106.44k stars 29.01k forks source link

windows build vs 17.10 error #54048

Closed bmatusiak closed 1 week ago

bmatusiak commented 1 month ago

Version

master/main branch

Platform

window 11 x64

vcbuild.bat

Looking for Python
Python found in C:\Program Files\Python312\\python.exe
Python 3.12.4
Looking for NASM
Looking for Visual Studio 2022
calling: "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\\Auxiliary\Build\vcvarsall.bat" amd64
**********************************************************************
** Visual Studio 2022 Developer Command Prompt v17.10.5
** Copyright (c) 2022 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'
Found MSVS version 17.0
Node.js doesn't compile with Visual Studio 17.10 Please use a different version.

just going off the docs to build for windows and last week node was building fine.

climba03003 commented 1 month ago

There is a compiler error on 17.10, so it is explicit blocked to build with 17.10. You can follow the issue on https://github.com/nodejs/build/issues/3739

bmatusiak commented 1 week ago

Building works for me now