test-http-outgoing-end-cork ignores platformTimeout and fail on slow archs

kapouer commented 2 months ago

Test

test-http-outgoing-end-cork

Platform

No response

Console output

not ok 1287 parallel/test-http-outgoing-end-cork
---
duration_ms: 6970.84500
severity: fail
exitcode: 1
stack: |-
    Sending req no 1
    node:assert:173
        throw err;
        ^

    AssertionError [ERR_ASSERTION]: () => {
            reject(new Error('Request timed out'));
        } at /tmp/autopkgtest-lxc.i258yc3s/downtmp/build.JNN/src/test/parallel/test-http-outgoing-end-cork.js:53
            at Timeout.mustNotCall [as _onTimeout] (/tmp/autopkgtest-lxc.i258yc3s/downtmp/build.JNN/src/test/common/index.js:547:12)
            at listOnTimeout (node:internal/timers:581:17)
            at process.processTimers (node:internal/timers:519:7) {
        generatedMessage: false,
        code: 'ERR_ASSERTION',
        actual: undefined,
        expected: undefined,
        operator: 'fail'
    }

    Node.js v20.16.0

Build links

Additional information

This build is for node 20.7.0 on riscv64 arch. I know it is not supported, but it would be nice anyway to have timeouts proportional to platformTimeout for all tests.

In that test, const REQ_TIMEOUT = 500; // Set max ms of request time before abort // Set total allowed test timeout to avoid infinite loop // that will hang test suite const TOTAL_TEST_TIMEOUT = 1000;

jakecastelli commented 1 month ago

This should be fixed in https://github.com/nodejs/node/pull/54591, please let me know if there's any issue 🙏

lpinca commented 1 month ago

I'm closing this as per https://github.com/nodejs/node/issues/54499#issuecomment-2345024595.

nodejs / node