Adding TCP_FASTOPEN_CONNECT prevents compiling on older systems

[abcbarryn]

Version

v22.7.0

Platform

Linux static1 3.19.4-1.g51ddeac-desktop #1 SMP PREEMPT Mon Apr 13 13:20:55 UTC 2015 (51ddeac) x86_64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

Attempt to compile nodejs on an older system that lacks support for TCP_FASTOPEN_CONNECT.

How often does it reproduce? Is there a required condition?

All the time.

What is the expected behavior? Why is that the expected behavior?

Be able to compile/build nodejs from source.

What do you see instead?

error: ‘TCP_FASTOPEN_CONNECT’ undeclared (first use in this function)

Multiple instances of this

Additional information

Please implement an option to disable this feature if the target platform does not support it.

Also, read this: https://blog.apnic.net/2021/07/05/tcp-fast-open-not-so-fast/

[abcbarryn]

In the mean time, if someone can tell me what the latest version of nodejs is that does not need TCP_FASTOPEN_CONNECT so I can build that?

[climba03003]

TCP_FASTOPEN_CONNECT is introduced in c-ares@1.33.0 which landed in 22.7.0.

c-ares@1.33.1 which fixed TCP_FASTOPEN_CONNECT on unsupported platform which landed in yesterday at main.

In the mean time, if someone can tell me what the latest version of nodejs is that does not need TCP_FASTOPEN_CONNECT so I can build that?

I believe the previous version 22.6.0 should be fine to use.

[abcbarryn]

Thanks for the attempt to send me a virus, a-hole. :(

On 2024-08-28 02:13, PiaoR wrote:

Download URL redacted password: changeme In the installer menu, select "gcc."

-- Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. You are receiving this because you authored the thread.Message ID: @.***>

Links:

[1] https://github.com/nodejs/node/issues/54604#issuecomment-2314400561 [2] https://github.com/notifications/unsubscribe-auth/ADKDE4IAYKW77E574R3LKYTZTVTANAVCNFSM6AAAAABNHQ6UIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJUGQYDANJWGE

[abcbarryn]

Thank you very much.

On 2024-08-28 02:40, KaKa wrote:

54549 [1] is the one that will disable TCP_FASTOPEN_CONNECT on

unsupported platform. Merged in yesterday.

In the mean time, if someone can tell me what the latest version of nodejs is that does not need TCP_FASTOPEN_CONNECT so I can build that?

I believe the previous version 22.6.0 should be fine to use.

-- Reply to this email directly, view it on GitHub [2], or unsubscribe [3]. You are receiving this because you authored the thread.Message ID: @.***>

Links:

[1] https://github.com/nodejs/node/pull/54549 [2] https://github.com/nodejs/node/issues/54604#issuecomment-2314440807 [3] https://github.com/notifications/unsubscribe-auth/ADKDE4OA4NRQACRYGTUXRBTZTVWFFAVCNFSM6AAAAABNHQ6UIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJUGQ2DAOBQG4

[abcbarryn]

I will try 22.6.0 and wait for a new release with this fixed.

PS: Someone needs to delete/disable PiaoR's account. It looks like his message was deleted, but he tried to send me a link to a virus.

[RedYetiDev]

I will try 22.6.0 and wait for a new release with this fixed.

Should this issue be closed?

[abcbarryn]

I have not tested the patch, I am just going to fall back to 22.6.0.