search

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
107.37k stars 29.49k forks source link

Coverage workflows fail on v22.x/v22.x-staging #55510

Open richardlau opened 5 hours ago

richardlau commented 5 hours ago

Starting with Node.js 22.8.0 (https://github.com/nodejs/node/commit/78ee90e5d90f4cd3d1921bd96cbac829fee3d7f0) the "without intl" coverage workflow started failing due to "does not meet the global threshold".

From Node.js 22.9.0 (https://github.com/nodejs/node/commit/4631be0311fbde7b77723757e15d025727399e63) both coverage workflows (with and without intl) fail due to the same reason (not meeting the global threshold). The situation persists through Node.js 22.10.0 and for the proposal for Node.js 22.11.0. (I'm going to ignore this for Node.js 22.11.0 as the release is intentionally not including changes beyond the metadata updates to mark the release as LTS.)

AFAIK the coverage workflows are passing on Node.js 23 and main and were passing on Node.js 22.7.0 (https://github.com/nodejs/node/commit/65eff1eb19a6d8e17435bbc4147ac4535e81abb4), so the question is what has/hasn't landed on v22.x-staging to cause the discrepancy? If there isn't an easy way to get the workflow passing again, can we lower the threshold for Node.js 22 only, or even disable the coverage workflows for 22?

cc @nodejs/releasers

RedYetiDev commented 3 hours ago

It's good to note that we are 0.07% away from the threshold, so maybe covering more methods would be a good solution.

richardlau commented 3 hours ago

It's good to note that we are 0.07% away from the threshold, so maybe covering more methods would be a good solution.

To be clear, I would not want us to add tests to v22.x-staging to increase the coverage that do not already exist on main (or v23.x), but if we can identify anything missing from v22.x-staging we can start a discussion (e.g. if it's related to a semver major PR not being on v22.x-staging maybe a partial backport is possible).