search

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
107.92k stars 29.75k forks source link

https://github.com/nodejs/node/pull/54677 should be backported to NodeJS 20 Branch #55726

Open alexsch01 opened 2 weeks ago

alexsch01 commented 2 weeks ago

Version

v20.18.0

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

This https://github.com/nodejs/node/pull/54677 is not implemented in v20.18.0 v18.20.4 and v22.11.0 (other LTS) versions have console.error not red

How often does it reproduce? Is there a required condition?

Every time

What is the expected behavior? Why is that the expected behavior?

This https://github.com/nodejs/node/pull/54677 should be implemented for v20.x same behavior as v18.20.4 and v22.11.0 (other LTS) versions

What do you see instead?

console.error is red in v20.18.0

node -e "console.error(process.version)"

is v20.18.0 and red

Additional information

The code that should be reverted first appeared in NodeJS 20 branch in v20.15.0

RedYetiDev commented 2 weeks ago

SGTM, just gotta wait for the next LTS release, and if it's not clean, open a backport PR

RedYetiDev commented 4 days ago

Fixed by #55879