nodejs / nodejs-dist-indexer

An application to create nodejs.org distribution index files: index.json and index.tab
MIT License
16 stars 15 forks source link

semantic-release can't push to repo #39

Open rvagg opened 3 hours ago

rvagg commented 3 hours ago

Halp, I don't remember how to solve this issue since the thing was changed in the nodejs org: https://github.com/nodejs/nodejs-dist-indexer/actions/runs/11470886766/job/31920891266

semantic-release cannot push the version tag to the branch main on the remote Git repository with URL https://x-access-token:[secure]@github.com/nodejs/nodejs-dist-indexer.git.

Screenshot 2024-10-23 at 12 06 44 PM

@richardlau? Someone else? What was the magic password to make this work?

richardlau commented 3 hours ago

I haven't had time to figure this out yet https://github.com/nodejs/nodejs-dist-indexer/issues/32. It may be as simple as

permissions:
  contents: read # for checkout

https://semantic-release.gitbook.io/semantic-release/recipes/ci-configurations/github-actions#.github-workflows-release.yml-configuration-for-node-projects or it may require a new token.

richardlau commented 3 hours ago

oh if it's for writing tags to the repo, probably

    permissions:
      contents: write # to be able to publish a GitHub release

(also from https://semantic-release.gitbook.io/semantic-release/recipes/ci-configurations/github-actions#.github-workflows-release.yml-configuration-for-node-projects)?

rvagg commented 2 hours ago

oh, that's right, now I remember we had to do that for the snap repo, thanks Richard!