nodejs / nodejs.org

The Node.js® Website
https://nodejs.org
MIT License
6.02k stars 6.17k forks source link

fix: svg warning in HexagonGrid #6681

Closed theoludwig closed 2 months ago

theoludwig commented 2 months ago

Replace fill-opacity by fillOpacity.

Description

There is a warning about the <HexagonGrid /> svg:

app-index.tsx:26 Warning: Invalid DOM property `fill-opacity`. Did you mean `fillOpacity`?
    at path
    at g
    at svg
    at div
    at div
    at MatterProvider 

Validation

This PR fixes this warning (error is not printed anymore in the console).

Check List

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 30, 2024 6:02pm
github-actions[bot] commented 2 months ago
Lighthouse Results URL Performance Accessibility Best Practices SEO Report
/en 🟠 85 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 98 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗
github-actions[bot] commented 2 months ago

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.04% (588/653) 76.08% (175/230) 92.18% (118/128)

Unit Test Report

Tests Skipped Failures Errors Time
128 0 :zzz: 0 :x: 0 :fire: 5.686s :stopwatch:
AugustinMauroy commented 2 months ago

Question it's not need to write like html for OG-image because it's was implemented like that when Brian create og engine.

ovflowd commented 2 months ago

Question it's not need to write like html for OG-image because it's was implemented like that when Brian create og engine.

That SVG is a React Component, so it must follow React Props.