Changes in Copy to ClipBoard button in main page

nodejs / nodejs.org

The Node.js® Website

https://nodejs.org

MIT License

6.15k stars 6.22k forks source link

Changes in Copy to ClipBoard button in main page #6685

Closed TenzDelek closed 5 months ago

TenzDelek commented 5 months ago

URL:

https://nodejs.org/en

Browser Name:

brave

Browser Version:

1.65.123

Operating System:

Windows 11

How to reproduce the issue:

The Problem:

the current copy to clipboard has a display like this

making it not so UI friendly. and in smaller screen it is not even showing

Approach:

instead of the popup like the current version, we can so make it transition to a state of true and false when it is being clicked.
so when it is click it transition to the clicked state.

AugustinMauroy commented 5 months ago

I remove bug label because that not a bug. also why remove toast ? What's wrong with announcing that something non-visual has happened with a toast?

TenzDelek commented 5 months ago

@AugustinMauroy personally, it feels more intrusive to have a change in the button itself than displaying a toast, other than that no such reason to remove, :smiley:

also the current display is happening like this in smaller screen:

AugustinMauroy commented 5 months ago

Ok, so there are an issue for displaying toast on small screen. And you propose to remove toast.

But you can't mix the two. One is a problem of consepction and the other is an ideology/point of view.

TenzDelek commented 5 months ago

@AugustinMauroy agreed with your input, my point was to show the underlying issue with the current toast, plus an approach to use state base instead of a toast. If you feel the toast is fine , then I guess it's fine to leave it as such. 👍