Fixed: fixed the breadcrumb inconsistency

[TenzDelek]

Fixes #6679

Description

Validation

before:

after:

Check List

• [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
• [x] I have run npm run format to ensure the code follows the style guide.
• [x] I have run npm run test to check if all tests are passing.
• [x] I have run npx turbo build to check if the website builds without errors.
• [ ] I've covered new added functionality with unit tests if necessary.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	May 4, 2024 2:45pm

[github-actions[bot]]

Lighthouse Results URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 97	🟢 100	🟢 96	🟢 91	🔗
/en/about	🟢 100	🟢 100	🟢 96	🟢 91	🔗
/en/about/previous-releases	🟢 99	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 98	🟢 100	🟢 96	🟢 92	🔗

[github-actions[bot]]

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	90.04% (588/653)	76.08% (175/230)	92.18% (118/128)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
128	0 :zzz:	0 :x:	0 :fire:	6.293s :stopwatch:

[AugustinMauroy]

There are still strange behavior https://nodejs-org-git-fork-tenzdelek-fix-breadcrumb-inco-7252f3-openjs.vercel.app/en/learn/getting-started/ecmascript-2015-es6-and-beyond

[TenzDelek]

There are still strange behavior https://nodejs-org-git-fork-tenzdelek-fix-breadcrumb-inco-7252f3-openjs.vercel.app/en/learn/getting-started/ecmascript-2015-es6-and-beyond

@AugustinMauroy thank you for pointing that out, after checking the prior logic i found out that we are not checking the dashtocamel for digit thats why it was acting like that before:

after:

have made the changes in the dashtocamel file..

[TenzDelek]

https://github.com/nodejs/nodejs.org/issues/6679#issuecomment-2094119357 @mikeesto @ovflowd @AugustinMauroy regarding this comment raise, I tried to look through it. I think that the reason why the getInvolved is not getting its breadcrumbs fix, is the way we are giving the path for the about. currently the about items are its

so that for about section it is working as fine. first getting in the about(True) then goes in its item, then match with the item.

the Error parts starts from here

but for the get Involved the navigation tree is same (about) but when we tried to get in the tree it doesnt work as the item inside the tree is of about and not of get involved. resulting in false in every iteration :

Solution

my thoughts-

• currently there is about only in the tree, there should be i think that the reason behind it is how we are structuring the object of about, i think that we need to change the path such that inside the about there should be two object : aboutin and the getinvolved. (check the navigation tree) then we can decide which one we can traverse into about { [aboutin,{its item..}], [getinvolved,{is items..}]

  I don't think i will be able to change the object structure as it might break the other component, if a member of node can help with this. it is highly appreciated.

[TenzDelek]

as the issue is fixed in #6710 , closing this pr