tquocanvn commented 2 months ago

Description

Update side bar navigation key name to match with route path in navigation.json
Add target side bar nav keys to HOC withBreadcrumbs.tsx to get directly sidebar navigation data for About.tsx and Learn.tsx page.
Update logic on matching route path in function getBreadrumbs of HOC withBreadcrumbs.tsx.

Validation

Open page path /en/about/, go through all items in side bar navigation to see it shows correct breadcrumbs data.

6679

Fixes #6679

[x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
[x] I have run npm run format to ensure the code follows the style guide.
[x] I have run npm run test to check if all tests are passing.
[x] I have run npx turbo build to check if the website builds without errors.
[ ] I've covered new added functionality with unit tests if necessary.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	May 4, 2024 5:11pm

github-actions[bot] commented 2 months ago

Lighthouse Results URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 97	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 98	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 99	🟢 100	🟢 96	🟢 92	🔗

github-actions[bot] commented 2 months ago

Lines	Statements	Branches	Functions
	90.04% (588/653)	76.08% (175/230)	92.18% (118/128)

Tests	Skipped	Failures	Errors	Time
128	0 :zzz:	0 :x:	0 :fire:	6.137s :stopwatch:

bmuenzenmeyer commented 2 months ago

thanks for this thoughtful contribution @tquocanvn - sorry for the delay!