search

nodejs / nodejs.org

The Node.js® Website
https://nodejs.org
MIT License
6.02k stars 6.17k forks source link

Blog Word Break #6711

Closed MitchTalmadge closed 2 months ago

MitchTalmadge commented 2 months ago

URL:

https://nodejs.org/en/blog/announcements/v22-release-announce

Browser Name:

Arc

Browser Version:

1.41.0 (49440)

Operating System:

MacOS 14.4.1 (23E224)

How to reproduce the issue:

The blog currently uses word-break: break-all for the body text. This seems like a bug to me. It makes it difficult to read the posts. I would recommend changing it to word-break: normal.

  1. Go to https://nodejs.org/en/blog/announcements/v22-release-announce
  2. Look at the end of each line of text. Many words will be chopped off, not even hyphenated.

It looks like it was introduced in #6680. I think that change was only supposed to affect small screens, like phones, but I am using a full desktop browser on a large screen and having the issue.

Before

Notice the way that every line ends in a broken word.

image

After (word-break: normal)

image

AugustinMauroy commented 2 months ago

I take a look to the pr and I didn't found any reason behind. so let's revert this change.

AugustinMauroy commented 2 months ago

[!NOTE] On project we use tailwind so you I'll need to use word-break