nodejs / nodejs.org

The Node.js® Website

https://nodejs.org

MIT License

6.15k stars 6.21k forks source link

Closed styfle closed 4 months ago

styfle commented 4 months ago

Description

I believe nvm is always lowercase as seen in their readme

None

[ ] I have read the Contributing Guidelines and made commit messages that follow the guideline.
[ ] I have run npm run format to ensure the code follows the style guide.
[ ] I have run npm run test to check if all tests are passing.
[ ] I have run npx turbo build to check if the website builds without errors.
[ ] I've covered new added functionality with unit tests if necessary.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	May 14, 2024 4:25pm

github-actions[bot] commented 4 months ago

Lighthouse Results URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 97	🟢 100	🟢 96	🟢 91	🔗
/en/about	🟢 98	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 100	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 98	🟢 100	🟢 96	🟢 92	🔗

github-actions[bot] commented 4 months ago

Lines	Statements	Branches	Functions
	90.04% (588/653)	76.08% (175/230)	92.18% (118/128)

Tests	Skipped	Failures	Errors	Time
128	0 :zzz:	0 :x:	0 :fire:	6.011s :stopwatch:

styfle commented 4 months ago

Just, is there any other mention of nvm that might be in the wrong case?

Good point, I just pushed another commit (f415c4d) where the code comment was using the wrong case as well.