fix: added digit regex

[TenzDelek]

• additional small changes for breadcrumb the url of the ECMAScript in learn page contain digit after the dash ("https://nodejs.org/en/learn/getting-started/ecmascript-2015-es6-and-beyond") which is not handle resulting in below behavior

the current behavior:

after adding digit regex:

• [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
• [x] I have run npm run format to ensure the code follows the style guide.
• [x] I have run npm run test to check if all tests are passing.
• [x] I have run npx turbo build to check if the website builds without errors.
• [ ] I've covered new added functionality with unit tests if necessary.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	May 21, 2024 8:52am

[AugustinMauroy]

I think it would be good to have a unit test for this would you do it? That would make it possible once and for all to see if all the use cases are correct.

[TenzDelek]

I think it would be good to have a unit test for this would you do it? That would make it possible once and for all to see if all the use cases are correct.

I believe I don't have prior experience with writing unit test for now, but I would love to do it . If it possible for any one of the members to guide me it can be helpful.

[AugustinMauroy]

OK I can help you We have a docs General Guidelines for Unit Tests can help you

there are already a unit test file for util/stringUtils.ts it's util/__tests__/stringUtils.test.ts.

to add the test:

1. import function
2. each use case of the function must be covered by an it. For example : it("dashToCamelCase should work with number", () => {
3. need to use expect to "expect" what test should test. I recommend you to read this doc https://jestjs.io/docs/expect

npm run test to run test suit. if everything pass you can commit ! also you can use npm run test:unit:watch to start watching file so each time you will save it's will re-run the task

[TenzDelek]

OK I can help you We have a docs General Guidelines for Unit Tests can help you

there are already a unit test file for util/stringUtils.ts it's util/__tests__/stringUtils.test.ts.

to add the test:

1. import function
2. each use case of the function must be covered by an it. For example : it("dashToCamelCase should work with number", () => {
3. need to use expect to "expect" what test should test. I recommend you to read this doc https://jestjs.io/docs/expect

npm run test to run test suit. if everything pass you can commit ! also you can use npm run test:unit:watch to start watching file so each time you will save it's will re-run the task

Thanks a lot !! will go through the docs and check

[TenzDelek]

hello @AugustinMauroy the testcases are passing for dashtocamel. (can you check once whether the testcase are fine. i used some random values) thanks for the help.

also one thing to be note, during the test, I think one of the testcase (unrelated to this pr) is failing.

[github-actions[bot]]

Lighthouse Results URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟠 84	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 98	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 98	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 94	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 97	🟢 100	🟢 100	🟢 92	🔗

[github-actions[bot]]

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	90.51% (592/654)	76.08% (175/230)	93.79% (121/129)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
131	0 :zzz:	0 :x:	0 :fire:	6.47s :stopwatch:

[AugustinMauroy]

@TenzDelek strange because here on CI it's pass

[TenzDelek]

@AugustinMauroy again thanks for the help, that's the one thing that I love about open source is that we can learn and explore new things. Happy learning 🙏🏼

[AugustinMauroy]

@AugustinMauroy again thanks for the help, that's the one thing that I love about open source is that we can learn and explore new things. Happy learning 🙏🏼

I try to do my best, but I'm not a teacher 😄.

[bmuenzenmeyer]

https://nodejs-org-git-fork-tenzdelek-fix-added-digit-regex-openjs.vercel.app/en/learn/manipulating-files/working-with-different-filesystems still looks broken to me

maybe we need a combo of both solutions 😄

[ovflowd]

As commented on the other PR, I'm closing this one in favour of @abizek's PR 🙇