nodejs / nodejs.org

The Node.js® Website
https://nodejs.org
MIT License
6k stars 6.16k forks source link

fix: disabled button #6731

Closed AugustinMauroy closed 1 month ago

AugustinMauroy commented 1 month ago

Description

When you haver disabled button it's play hover effect with a cross cursor. It's contradictory to have an effect that encourages you to click and a cursor that tells you it's not possible.

It's why I disable hover effect if aria-disabled is true

Validation

Before :

https://github.com/nodejs/nodejs.org/assets/97875033/9f69d471-6b69-48f3-8df3-dd8cdbabeb27

After :

https://github.com/nodejs/nodejs.org/assets/97875033/6e3c8f2d-1451-4201-b2e0-e1223050c26c

Related Issues

No related Issues

Check List

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 21, 2024 0:34am
github-actions[bot] commented 1 month ago
Lighthouse Results URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 94 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 98 🟢 100 🟢 100 🟢 92 🔗
github-actions[bot] commented 1 month ago

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.06% (589/654) 76.08% (175/230) 92.24% (119/129)

Unit Test Report

Tests Skipped Failures Errors Time
128 0 :zzz: 0 :x: 0 :fire: 6.346s :stopwatch: