nodejs / nodejs.org

The Node.js® Website
https://nodejs.org
MIT License
6k stars 6.16k forks source link

having logo in pride style #6733

Closed AugustinMauroy closed 1 month ago

AugustinMauroy commented 1 month ago

Moderation note: Hey, if you have issues with the project's decision here, please send them to report@nodejs.org instead of opening new issues. That does not help the project and only constitutes of harassment.


June 1 to June 30 is Pride, a month-long to celebrate LGBTQIA+ community. I propose that we have our logo with the LGBTQIA+ flag. In order to bring an open support to all the community.

What can we do? I propose to have a code that checks if we are between two dates with dateIsBetween already implemented if the condition is true we put the logo variant. I thinks we can just touch the nav logo.

Here logo:

Capture d’écran 2024-05-22 à 09 39 23

[!NOTE] It's will not affect UX

ovflowd commented 1 month ago

cc @nodejs/nodejs-website and @kyliewd as it affects branding 👀

ovflowd commented 1 month ago

Also instead of a date checker, we can add the logo variants to the site config and simply upload the pride logos on our static folder, and during pride month swap those logos on the settings.

AugustinMauroy commented 1 month ago

and during pride month swap those logos on the settings.

You're not wrong and it's reduce calculation, it just requires human action every time.

kyliewd commented 1 month ago

this is fine with me

ovflowd commented 1 month ago

Feel free to proceed with a PR, Augustin :)

benjamingr commented 1 month ago

Hey, if you have issues with the project's decision here, please send them to report@nodejs.org instead of opening new issues. That does not help the project and only constitutes of harassment.

benjamingr commented 1 month ago

@marco-ippolito I absolutely agree and we should amend our process to require that in the future. I plan to raise it Wednesday on the TSC meeting.

marco-ippolito commented 1 month ago

I believe @nodejs/tsc should be notified when adding flags to the website Edit: I mistakenly deleted comment from mobile.

mcollina commented 1 month ago

I'm sorry but this should have been run via the tsc.

benjamingr commented 1 month ago

I opened a governance change PR at https://github.com/nodejs/nodejs.org/pull/6772

ovflowd commented 1 month ago

This issue is locked, can we please not comment anymore here?

It genuinely doesn't make sense to keep commenting here. Appropriate governance changes are being held.