nodejs / nodejs.org

The Node.js® Website

https://nodejs.org

MIT License

6.15k stars 6.21k forks source link

feat(pride logo): introduce #6734

Closed AugustinMauroy closed 4 months ago

AugustinMauroy commented 4 months ago

Description

Read issues #6733 to understand what is going on.

Validation

Related Issues

Related to #6733

Check List

[x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
[x] I have run npm run format to ensure the code follows the style guide.
[x] I have run npm run test to check if all tests are passing.
[x] I have run npx turbo build to check if the website builds without errors.
[x] I've covered new added functionality with unit tests if necessary.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	May 31, 2024 7:14am

github-actions[bot] commented 4 months ago

Lighthouse Results URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 98	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 98	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 94	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 100	🟢 100	🟢 100	🟢 92	🔗

github-actions[bot] commented 4 months ago

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	90.06% (589/654)	76.08% (175/230)	92.24% (119/129)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
128	0 :zzz:	0 :x:	0 :fire:	5.884s :stopwatch:

bmuenzenmeyer commented 4 months ago

I'm thinking we get this released sooner rather than later, even if we aren't in complete alignment on the approach.

bmuenzenmeyer commented 4 months ago

ugh - on mobile this all looked green - something's wrong post-merge - looking into it

AugustinMauroy commented 4 months ago

@bmuenzenmeyer ?

AugustinMauroy commented 4 months ago

I thinks It’s small delay from Vercel deployment

bmuenzenmeyer commented 4 months ago

@AugustinMauroy https://github.com/nodejs/nodejs.org/commits/main/

AugustinMauroy commented 4 months ago

Oh my bad I thinks you talk about logo 😅

bmuenzenmeyer commented 4 months ago

i'm glad its not outright broken, but apologies on any instability i rushed through - mobile is clearly not a good way to review CI status checks - thought i see here everything looks green.

i suggest we simply roll forward with a merge of a dependency update or something