search

nodejs / nodejs.org

The Node.js® Website
https://nodejs.org
MIT License
6k stars 6.16k forks source link

feat(meta): support nodejs v22 #6746

Closed RedYetiDev closed 1 month ago

RedYetiDev commented 1 month ago

Follow up on #6732

This PR does the exact same as #6732, except it doesn't modify the package.json to officially allow support for Node.js v22, as Vercel doesn't support v22.

This PR allows this to build on Node.js v22, but doesn't recommend building on that version.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 29, 2024 0:17am
ovflowd commented 1 month ago

Again, these changes will probably work if we're using the latest versions of Node v20; If someone uses Node v20.0, I don't believe it would work. But I'm willing to give it a try.

AugustinMauroy commented 1 month ago

If someone uses Node v20.0, I don't believe it would work

You're probably right

github-actions[bot] commented 1 month ago
Lighthouse Results URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗
github-actions[bot] commented 1 month ago

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 :zzz: 0 :x: 0 :fire: 6.01s :stopwatch:
ovflowd commented 1 month ago

Reverting. As I foresaw, it broke specific paths. Let's not use v22 exclusive features until we're on v22.