feat(copy): inline copy/paste for clipboard

nodejs / nodejs.org

The Node.js® Website

https://nodejs.org

MIT License

6k stars 6.16k forks source link

Closed RedYetiDev closed 1 month ago

RedYetiDev commented 1 month ago

This PR changes the 'Copy to Clipboard' button's notification on copy to an inline text change.

[x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
[x] I have run npm run format to ensure the code follows the style guide.
[x] I have run npm run test to check if all tests are passing.
[x] I have run npx turbo build to check if the website builds without errors.
[x] I've covered new added functionality with unit tests if necessary.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	May 29, 2024 0:30am

RedYetiDev commented 1 month ago

commit leftover from other pr

mikeesto commented 1 month ago

It would be good to know what the motivation is for this change?

ovflowd commented 1 month ago

Sorry, we aren't going to land this change. Could you please open issues beforehand to foster discussion/communication before jumping to make PRs?

There are reasons why certain things are done they way they are and changing them on a whim or personal basis isn't constructive.

I'm closing this PR, and warning you yet again, please be considerate with maintainer's time.