Closed JakobJingleheimer closed 3 months ago
The latest updates on your projects. Learn more about Vercel for Git âïž
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
nodejs-org | â Ready (Inspect) | Visit Preview | Jun 6, 2024 8:15am |
Under what heading do y'all think this article belongs? Its own ("Testing") or a more generic, like "Getting Started"?
Also, it seems the menu is not dynamically generated. Could someone point me to where I need to update the menu? I can't access the new article in the preview deployment ð
Under what heading do y'all think this article belongs? Its own ("Testing") or a more generic, like "Getting Started"?
I thinks having a section call "nodejs test runner" with several pages for each use case. Example: "introduction" with explaining of what is a test runner what is the goal of test runner, "test front-end code", "2e2" with example to start nodejs app and test it with fetch api
Also, it seems the menu is not dynamically generated. Could someone point me to where I need to update the menu? I can't access the new article in the preview deployment ð
It's not dynamic so we can chose the order of article in nav. Yeah it's not documented ð
.
So you I'll need to update navigation.json
I thinks having a section call "nodejs test runner" with several pages for each use case. Example: "introduction" with explaining of what is a test runner what is the goal of test runner, "test front-end code", "2e2" with example to start nodejs app and test it with fetch api
I was wondering about this today. Do we want to have such opinionated articles? Ex this is what does and doesn't belong in a snapshot test, etc.
Also
jsx
ortsx
is isn't support on the website ? Do we really need it?
Ish? The example contains JSX and it kinda needs to.
@AugustinMauroy how did you access the published page? I tried to manually navigate to /en/learn/test-runner/using-test-runner
, but I get a 500
error.
@JakobJingleheimer here link of preview you can also access to it with npm run dev
Ish? The example contains JSX and it kinda needs to.
@ovflowd Would you prefer me to add it to this pr or another one?
Do we want to have such opinionated articles?
Why not ? I think it's an excellent solution for presenting all sorts of use cases.
@ovflowd Would you prefer me to add it to this pr or another one?
I'd rather not add syntax highlighting for JSX; if I recall, it has some of the largest bundles in terms of syntax highlighting. On that note, @AugustinMauroy can you investigate why upgrading to latest Next.js v14 breaks the build? I assume because we do some sort of dynamic imports somewhere or something that Next.js is not happy, I assume that it's something easy to fix. Unfortunately I don't have my PC with my right now.
Off topics but I'll take a look
I'd rather not add syntax highlighting for JSX; if I recall, it has some of the largest bundles in terms of syntax highlighting.
Ah, fair. But what should I do then? The use-case basically requires JSX. The amount of JSX in the example code though is tiny.
I'd rather not add syntax highlighting for JSX; if I recall, it has some of the largest bundles in terms of syntax highlighting.
Ah, fair. But what should I do then? The use-case basically requires JSX. The amount of JSX in the example code though is tiny.
Mark it just as ts or js :)
+1 for @mikeesto proposition but you have to bear in mind that the docs contain generic examples, so the learn section should be more based on concrete cases.
One thing that stood out to me is that the examples provided (from real-world projects) are relatively advanced. [âŠ] they might be expecting to learn how to test a function that sums two numbers.
bear in mind that the docs contain generic examples, so the learn section should be more based on concrete cases.
Yeah, exactly my thinking when I wrote this guide ð The simple stuff is easy to figure out, but the complicated stuff probably only a couple dozen people know enough to figure out.
That said, happy to subsequently expand with some simpler examples in between ServiceWorker
and sum()
.
Soo is this good to land?
as it I think we can land it
Lighthouse Results URL | Performance | Accessibility | Best Practices | SEO | Report |
---|---|---|---|---|---|
/en | ð 86 | ð¢ 100 | ð¢ 96 | ð¢ 91 | ð |
/en/about | ð¢ 100 | ð¢ 100 | ð¢ 96 | ð¢ 91 | ð |
/en/about/previous-releases | ð¢ 99 | ð¢ 100 | ð¢ 100 | ð¢ 92 | ð |
/en/download | ð¢ 100 | ð¢ 100 | ð¢ 100 | ð¢ 91 | ð |
/en/blog | ð¢ 100 | ð¢ 100 | ð¢ 96 | ð¢ 92 | ð |
Description
Adding learn ressources about nodejs test runner
Validation
Related Issues
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.