nodejs / nodejs.org

The Node.js® Website
https://nodejs.org
MIT License
6.15k stars 6.21k forks source link

chore: updated packages, fixed build bugs and migrated packages #6803

Closed ovflowd closed 3 months ago

ovflowd commented 4 months ago

Description

Validation

Local development, build and deployments should work as expected

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 5, 2024 8:40am
github-actions[bot] commented 4 months ago
Lighthouse Results URL Performance Accessibility Best Practices SEO Report
/en 🟢 91 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗
github-actions[bot] commented 4 months ago

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 :zzz: 0 :x: 0 :fire: 5.169s :stopwatch:
ovflowd commented 3 months ago

@MattIPv4 could you give a review? We need Web Infra to review this PR 🙇

ovflowd commented 3 months ago

I have this error on a clean pull of the repo - investigating

image

Is it a clean pull? It says there is already another process running. These DOCTYPE issues generally occur when we try to fetch Node.js data, but the server fails. (Like the releases, api posts, etc)... But LMK if you find anything!

bmuenzenmeyer commented 3 months ago

@ovflowd 3000 was another app running, not nodejs.org - i killed it and 3000 works fine

MattIPv4 commented 3 months ago

@MattIPv4 could you give a review? We need Web Infra to review this PR 🙇

Sorry for the slow response, am hiking around New Zealand currently. Looks like this was merged okay?