Closed canerakdas closed 2 weeks ago
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
nodejs-org | โ Ready (Inspect) | Visit Preview | Jun 9, 2024 8:37pm |
Before merging this development, the ORAMA_PRODUCTION_INDEX_ID and ORAMA_PRODUCTION_SECRET_KEY secrets need to be defined. I believe we should get support from @ovflowd or @bmuenzenmeyer for this ๐ I think we should first set these two values to point to the preview environment to ensure everything is working correctly, and then replace them with the production ones
Secrets Added ๐
Additionally, it would be helpful to ask the Orama team if indexing on every pull_request_target and push events would cause any issues on their side
cc @micheleriva
@ovflowd that looks good to me!
hmm - comparing experiences, the proposed search has odd headers
Not sue why the discrepancies, this PR doesn't affect the website at all...
hmm - comparing experiences, the proposed search has odd headers
As far as I understand; the current script works for windows-latest
and ubuntu-latest
. However, since windows-latest
runs later and the paths in the file located at this path come as shown in the image below;
The split in this line does not work correctly. Therefore, the script that runs later overwrites the index created in ubuntu-latest
, corrupting the existing indexes
Since we will only run this script on ubuntu-latest
, I think there won't be such an issue after merging this PR. Since the current production secrets are replaced with the preview ones, it would be beneficial to run pull_request_target
event in a different PR after this PR is merged and recheck the preview to ensure everything is working correctly ๐
Good analysis @canerakdas - I'm willing to get it a go today if we're all around to watch
Lighthouse Results URL | Performance | Accessibility | Best Practices | SEO | Report |
---|---|---|---|---|---|
/en | ๐ 87 | ๐ข 100 | ๐ข 100 | ๐ข 91 | ๐ |
/en/about | ๐ข 100 | ๐ข 100 | ๐ข 96 | ๐ข 91 | ๐ |
/en/about/previous-releases | ๐ข 96 | ๐ข 100 | ๐ข 100 | ๐ข 92 | ๐ |
/en/download | ๐ข 99 | ๐ข 100 | ๐ข 100 | ๐ข 91 | ๐ |
/en/blog | ๐ข 99 | ๐ข 100 | ๐ข 96 | ๐ข 92 | ๐ |
Description
In the previous PRs opened (#6814, #6806), we ensured that the Orama cloud sync script updates the preview environment on
push
andpull_request_target
events.With this PR, we aim to update the production indexes using this script on the
push
event instead of manually updating it and to update the preview environment onpull_request_target
events.Additionally, to prevent these scripts from running twice, we ensure they only run on
ubuntu-latest
runners. Since we are currently running it onwindows-latest
in the preview environment, the facets are currently not displayed correctly, likely due to differences in paths on Windows (You can check it in a sample preview build)Before merging this development, the
ORAMA_PRODUCTION_INDEX_ID
andORAMA_PRODUCTION_SECRET_KEY
secrets need to be defined. I believe we should get support from @ovflowd or @bmuenzenmeyer for this ๐ I think we should first set these two values to point to the preview environment to ensure everything is working correctly, and then replace them with the production onesAdditionally, it would be helpful to ask the Orama team if indexing on every
pull_request_target
andpush
events would cause any issues on their sideRelated Issues
Related to #6719