nodejs / nodejs.org

The Node.js® Website

https://nodejs.org

MIT License

5.99k stars 6.15k forks source link

Correct grammar and improve clarity #6826

Closed asdacosta closed 2 weeks ago

asdacosta commented 3 weeks ago

Description

Correct grammar and improve clarity

Validation

Confirmed

Related Issues

Check List

[x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
[x] I have run npm run format to ensure the code follows the style guide.
[x] I have run npm run test to check if all tests are passing.
[x] I have run npx turbo build to check if the website builds without errors.
[x] I've covered new added functionality with unit tests if necessary.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Jun 9, 2024 11:53pm

bmuenzenmeyer commented 3 weeks ago

While I appreciate the eye for detail, this is a low-quality PR to me that doesn't accomplish much other than what a grammar tool might suggest. I am 👎 but want other opinions.

asdacosta commented 3 weeks ago

While I appreciate the eye for detail, this is a low-quality PR to me that doesn't accomplish much other than what a grammar tool might suggest. I am 👎 but want other opinions.

If it’s even a subtle part of the phrase that is wrong, I think it’s worth correcting as it can change the whole meaning of what is being conveyed. Hence, it might seem like a ‘low-quality’ when it’s impact in the whole text is actually significant. We’re weighing between wrong grammar and correct one, which option is best…

AugustinMauroy commented 3 weeks ago

@bmuenzenmeyer I think it makes the text clearer

aymen94 commented 3 weeks ago

@asdacosta thanks for contributing 🎉

github-actions[bot] commented 2 weeks ago

Lighthouse Results URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 97	🟢 100	🟢 96	🟢 91	🔗
/en/about	🟢 96	🟢 100	🟢 96	🟢 91	🔗
/en/about/previous-releases	🟢 95	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 99	🟢 100	🟢 96	🟢 91	🔗
/en/blog	🟢 100	🟢 100	🟢 96	🟢 92	🔗

github-actions[bot] commented 2 weeks ago

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	90.67% (593/654)	76.08% (175/230)	94.57% (122/129)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
131	0 :zzz:	0 :x:	0 :fire:	5.605s :stopwatch: