search

nodejs / nodejs.org

The Node.js® Website
https://nodejs.org
MIT License
5.98k stars 6.15k forks source link

Footer missing on Learn layout #6829

Open bmuenzenmeyer opened 2 weeks ago

bmuenzenmeyer commented 2 weeks ago

https://nodejs.org/en/learn/getting-started/introduction-to-nodejs

Screenshot_20240610_181426_Chrome.jpg

mikeesto commented 2 weeks ago

Same on About too https://nodejs.org/en/about

Wellitsabhi commented 2 weeks ago

footer missing in 'About and 'Learn" layout , already on it,raising PR

ovflowd commented 1 week ago

Id say these pages are following the figmas, which have no footer. Now, not sure if we should add or not :shrug:

Im fine eitherways.

bmuenzenmeyer commented 1 week ago

I noticed that too but it looks REALLY out of place to me to selectively render a global component. I am surprised it didn't come up earlier, TBH.